enhance/routes - highlight active routes with green tag - #44
abiramcodes wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Comment |
cd383fa to
59e82fb
Compare
erkamyaman
left a comment
erkamyaman
left a comment
There was a problem hiding this comment.
AGENT: Verdict: close. Main already highlights the active route, so a second color adds noise.
app/src/pages/route-tree.ts:126-131on main: the active row already gets[class.active], and the styles at lines 319-328 give it an accent background plus a 3px accent bar on the left. The "active" tag sits inside that highlighted row. A green tag on an amber row mixes two signals for one state.app/src/pages/route-tree.ts:200-204(this PR): the colors are hard-coded (#14532d,#bbf7d0). The app uses design tokens now. If we ever want the tag itself to stand out, a token-based version is one rule:.tag.is-active { @include m.soft(var(--ok)); }. That follows the same pattern as.chip.onincomponent-tree.ts.- The PR also commits rebuilt
extension/ui/assets/*bundles. Main's CI rebuilds these and fails if they're stale, so they'd need regenerating anyway (pnpm extension:build).
Needs a rebase onto main.
|
@erkamyaman , the first line stays the verdict as close. |
|
Close it for now. Main already highlights the active route, so the token note was only for a future change if we ever want the tag itself to stand out. Thanks for the quick turnaround! |
|
As discussed, closing the PR now |
2 participants
This PR adds styling to the already present active tab in the devtools routes - routes which helps to observe the active route with ease.